-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address deprecation warnings for tests and add local install gradle action #19
base: master
Are you sure you want to change the base?
Conversation
@@ -78,10 +78,43 @@ dependencies { | |||
modules { | |||
module("commons-logging:commons-logging") { replacedBy("org.slf4j:jcl-over-slf4j") } | |||
} | |||
|
|||
// Add this line to explicitly declare the test framework launcher | |||
testRuntimeOnly 'org.junit.platform:junit-platform-launcher' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an addition to address the warning when running make test
. The warning was:
./gradlew test --warning-mode all
Task :plugins:nf-hello:test
The automatic loading of test framework implementation dependencies has been deprecated. This is scheduled to be removed in Gradle 9.0. Declare the desired test framework directly on the test suite or explicitly declare the test framework implementation dependencies on the test's runtime classpath. Consult the upgrading guide for further information: https://docs.gradle.org/8.4/userguide/upgrading_version_8.html#test_framework_implementation_dependencies
The settings on this repo require you to both 'sign-off' ( |
0da2576
to
9553876
Compare
Signed and delivered 🫡 |
Signed-off-by: Rob Syme <[email protected]>
This fix is to address the deprecation warning that occurs when running tests. This solution follows the recommended approach from the Gradle documentation and should resolve the deprecation warning while maintaining the same test functionality. Signed-off-by: Rob Syme <[email protected]>
Signed-off-by: Rob Syme <[email protected]>
Co-authored-by: Tom Sellman <[email protected]> Signed-off-by: Rob Syme <[email protected]>
Co-authored-by: Tom Sellman <[email protected]> Signed-off-by: Rob Syme <[email protected]>
28daf80
to
e633cc1
Compare
This adds a new make command and corresponding gradle task to install the plugin in the user's local plugins directory. This is to make it a little bit easier to get started with plugin development.